forked from project-chip/connectedhomeip
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for Thread Synchronized Sleepy End Devices #66
Open
kkasperczyk-no
wants to merge
3
commits into
master
Choose a base branch
from
ssed_thread
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thread 1.2 allows to use Synchronized Sleepy End Devices that doesn't need to poll parent for data like traditional SED, but wakes up in scheduled time slots to listen for messages without transmitting requests to parent. * Refactored naming for sleepy end devices, as everywhere the polling mechanism is assumed. Basically renamed polling intervals to intervals and fast/slow polling mode to active/idle mode. * Added CHIP_DEVICE_CONFIG_THREAD_SSED that allows to enable Thread SSED support. * Added new Thread kThreadDeviceType_SynchronizedSleepyEndDevice device type * Added calculating communication intervals for Thread SSED based on CSL period instead of poll period.
kkasperczyk-no
requested review from
ArekBalysNordic,
Damian-Nordic,
LuDuda and
markaj-nordic
April 15, 2022 13:28
ArekBalysNordic
approved these changes
Apr 20, 2022
@@ -1682,6 +1690,7 @@ CHIP_ERROR GenericThreadStackManagerImpl_OpenThread<ImplClass>::DoInit(otInstanc | |||
initNetworkCommissioningThreadDriver(); | |||
|
|||
exit: | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this new line needed?
src/platform/OpenThread/GenericThreadStackManagerImpl_OpenThread.cpp
Outdated
Show resolved
Hide resolved
src/platform/OpenThread/GenericThreadStackManagerImpl_OpenThread.cpp
Outdated
Show resolved
Hide resolved
src/platform/OpenThread/GenericThreadStackManagerImpl_OpenThread.cpp
Outdated
Show resolved
Hide resolved
src/platform/OpenThread/GenericThreadStackManagerImpl_OpenThread.cpp
Outdated
Show resolved
Hide resolved
src/platform/OpenThread/GenericThreadStackManagerImpl_OpenThread.cpp
Outdated
Show resolved
Hide resolved
Damian-Nordic
approved these changes
Apr 21, 2022
LuDuda
approved these changes
Apr 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Thread 1.2 allows to use Synchronized Sleepy End Devices
that doesn't need to poll parent for data like traditional SED,
but wakes up in scheduled time slots to listen for messages
without transmitting requests to parent.
Change overview
the polling mechanism is assumed. Basically renamed polling
intervals to intervals and fast/slow polling mode to
active/idle mode.
Thread SSED support.
device type
on CSL period instead of poll period.